feat: subfile as sublink fallback #726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should work, but need more test |
st0nie
changed the title
st0nie
force-pushed
the
add-persist
branch
2 times, most recently
from
03280af to
d6dbabf
Compare
mzz2017
reviewed
Dec 31, 2024
st0nie
force-pushed
the
add-persist
branch
2 times, most recently
from
ca4de62 to
de90c0e
Compare
mzz2017
reviewed
Jan 2, 2025
st0nie
force-pushed
the
add-persist
branch
2 times, most recently
from
196719f to
6b89a4d
Compare
|
If a persistent file is not belonging to any tag, it will be deleted on reload |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
close #598
The current behavior is that dae will try to pull the subscription on startup as well as reload, and will not use the subscription if the pull fails.
This pr introduces
https-fileandhttp-filesubscriptions (persistent subscriptions), the pull behavior is the same as forhttpsandhttp, but if the pull fails, it tries to use the persistent file (in the config_directory/persist.d/tag_name.sub), and if the pull succeeds, it will update the persistent file.Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result